Skip to content

Support windows#5

Closed
yms2772 wants to merge 1 commit into
Davincible:masterfrom
yms2772:windows
Closed

Support windows#5
yms2772 wants to merge 1 commit into
Davincible:masterfrom
yms2772:windows

Conversation

@yms2772

@yms2772 yms2772 commented Jan 2, 2023

Copy link
Copy Markdown

Separating Unix files from Windows files.

@Davincible

Copy link
Copy Markdown
Owner

What is the benefit of this exactly? If I see correctly, in the windows file you removed the headless option, thus only non-headless is supported here, which already should work as is.

@yms2772

yms2772 commented Jan 2, 2023

Copy link
Copy Markdown
Author

What is the benefit of this exactly? If I see correctly, in the windows file you removed the headless option, thus only non-headless is supported here, which already should work as is.

As with #2 , when I "go get" on Windows, I get the error "type *syscall.SysProcAttr has no field or method Pdeathsig". To prevent this, I've separated the files into Windows and Unix.

@Davincible

Copy link
Copy Markdown
Owner

Ah I see. This quite a heavy workaround, lets first see if we can remove SysProcAttr. I copied it over from some other code, perhaps we can test without / find another way

@themihai

themihai commented Feb 7, 2023

Copy link
Copy Markdown

The same issue exists on MacOS

@mihaiav

mihaiav commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

I've submitted a PR ( #7 ) to build both on MacOS and Windows(and linux). Unless there is something I'm missing I believe this PR is toast as it copies unnecessary code that does not work anyway (i.e. Xvfb is not supported on windows ).

@Davincible

Copy link
Copy Markdown
Owner

@mihaiav @yms2772 I have tried to make a less drastic fix in #8 could you please check if this fixes it for you?

@Davincible

Copy link
Copy Markdown
Owner

Closing in favor of #7

From here on out we can start looking into how to support headless mode on the different platforms. If you have any ideas please let me know or PR!

Thank you for the work and the input @yms2772 @mihaiav

@Davincible Davincible closed this Mar 5, 2023
@yms2772 yms2772 deleted the windows branch October 22, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants